Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.python-openems: init at unstable-2020-02-15 #99880

Merged
merged 1 commit into from Oct 17, 2020

Conversation

@matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Oct 6, 2020

Motivation for this change

Adds python bindings for openems. Last piece of this PR. @jonringer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
nativeBuildInputs = [
cython
boost
];
Copy link
Contributor

@jonringer jonringer Oct 6, 2020

boost is usually linked against, and should go into buildInputs

Suggested change
nativeBuildInputs = [
cython
boost
];
nativeBuildInputs = [
cython
];
buildInputs = [
boost
];

Copy link
Contributor

@jonringer jonringer Oct 6, 2020

although this is refering to the python package, not actually sure about this case

cc @FRidh

@lukego
Copy link
Contributor

@lukego lukego commented Oct 13, 2020

Just want to say thanks for doing this packaging work!

@matthuszagh
Copy link
Contributor Author

@matthuszagh matthuszagh commented Oct 13, 2020

I'm glad it's useful!

@matthuszagh
Copy link
Contributor Author

@matthuszagh matthuszagh commented Oct 17, 2020

@jonringer added imports check.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 99880 1

2 packages built:
  • python37Packages.python-openems
  • python38Packages.python-openems

@jonringer jonringer merged commit 0c69551 into NixOS:master Oct 17, 2020
13 of 16 checks passed
@matthuszagh matthuszagh deleted the python-openems branch Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants