Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: ensure pipewire is only enabled with wayland & webrtc #99902

Merged
merged 1 commit into from Oct 7, 2020

Conversation

@andir
Copy link
Member

@andir andir commented Oct 6, 2020

Motivation for this change

This ensures that we aren't applying any of the experiemental pipewire
patches when the dependencies aren't enabled. As of now pipewire only
works with wayland and webrtc. If either of them are not activated we
can't build with pipewireSupport and we should not.

This is the follow-up to the changes I added to #99692.

Things done
  • built firefox with pipewire and without, ensured that wayland & webrtc must be on for eval to succeed
This ensures that we aren't applying any of the experiemental pipewire
patches when the dependencies aren't enabled. As of now pipewire only
works with wayland and webrtc. If either of them are not activated we
can't build with pipewireSupport and we should not.
@ofborg ofborg bot requested a review from edolstra Oct 6, 2020
@andir andir merged commit bffeb5f into NixOS:master Oct 7, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5a01d5"; rev="a5a01d56a20ea7bfbc4c0e3b376f95d3de467a4d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5a01d5"; rev="a5a01d56a20ea7bfbc4c0e3b376f95d3de467a4d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5a01d5"; rev="a5a01d56a20ea7bfbc4c0e3b376f95d3de467a4d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5a01d5"; rev="a5a01d56a20ea7bfbc4c0e3b376f95d3de467a4d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5a01d5"; rev="a5a01d56a20ea7bfbc4c0e3b376f95d3de467a4d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5a01d5"; rev="a5a01d56a20ea7bfbc4c0e3b376f95d3de467a4d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5a01d5"; rev="a5a01d56a20ea7bfbc4c0e3b376f95d3de467a4d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@andir andir deleted the andir:firefox-pipewire-optional branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.