Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.texlive: init #99910

Merged
merged 1 commit into from Oct 9, 2020
Merged

tests.texlive: init #99910

merged 1 commit into from Oct 9, 2020

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Oct 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@veprbl veprbl force-pushed the pr/texlive_tests branch from 14e8d88 to 074f6d9 Oct 6, 2020
@veprbl
Copy link
Member Author

@veprbl veprbl commented Oct 7, 2020

@GrahamcOfBorg build tests.texlive

@veprbl veprbl requested a review from Mathnerd314 Oct 9, 2020
Copy link
Contributor

@Mathnerd314 Mathnerd314 left a comment

It looks fine to me.

@veprbl veprbl merged commit 4d15ce5 into NixOS:master Oct 9, 2020
18 of 19 checks passed
@veprbl veprbl deleted the pr/texlive_tests branch Oct 9, 2020
@veprbl veprbl self-assigned this Oct 9, 2020
@veprbl veprbl restored the pr/texlive_tests branch Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants