Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/acme: Fix ocspMustStaple option and add test #99912

Merged
merged 1 commit into from Oct 11, 2020
Merged

Conversation

@m1cr0man
Copy link
Contributor

@m1cr0man m1cr0man commented Oct 6, 2020

Closes #99584

Some of the testing setup for OCSP checking was wrong and has been fixed too.

This should probably be backported too.

Ping @NixOS/acme

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Some of the testing setup for OCSP checking was wrong and
has been fixed too.
flokli
flokli approved these changes Oct 11, 2020
flokli added a commit that referenced this issue Oct 11, 2020
nixos/acme: Fix ocspMustStaple option and add test
@flokli flokli merged commit a1cb021 into NixOS:master Oct 11, 2020
16 checks passed
@flokli
Copy link
Contributor

@flokli flokli commented Oct 11, 2020

Backported to 20.09 in 2920c04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants