Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter: Bump and add dart cache to flutter #99920

Merged
merged 1 commit into from Oct 30, 2020

Conversation

@ericdallo
Copy link
Member

@ericdallo ericdallo commented Oct 7, 2020

Motivation for this change
  • Flutter requires dart-sdk cache to work propertly
  • bump flutter version to latest

Fixes #98405

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
channel = "stable";
version = "1.22.0";
Comment on lines 23 to 24

This comment has been minimized.

@babariviere

babariviere Oct 7, 2020
Member

Shouldn't it be beta instead of stable? Latest beta version is 1.22.0-12.3.pre

This comment has been minimized.

@ericdallo

ericdallo Oct 7, 2020
Author Member

Sorry, For some reason when I run flutter --version from beta channel it returns exactly the same for stable. But checking the git version of flutter repo, I think you are right, done!

This comment has been minimized.

@ericdallo

ericdallo Oct 7, 2020
Author Member

Could you please take a look again @babariviere ?

@ericdallo ericdallo force-pushed the ericdallo:add-dart-to-flutter branch 2 times, most recently from 54377b9 to cadfab0 Oct 7, 2020
@ofborg ofborg bot added the 8.has: clean-up label Oct 7, 2020
@ofborg ofborg bot requested a review from babariviere Oct 7, 2020
Copy link
Member

@babariviere babariviere left a comment

LGTM

@ericdallo
Copy link
Member Author

@ericdallo ericdallo commented Oct 7, 2020

@danieldk or @worldofpeace could you please merge?

@storvik
Copy link

@storvik storvik commented Oct 21, 2020

Just tested this with Nix and Ubuntu. Flutter and dart development tools seems to be working as expected 👍

@ericdallo
Copy link
Member Author

@ericdallo ericdallo commented Oct 21, 2020

@jonringer maybe you can help us merging that?

@ericdallo
Copy link
Member Author

@ericdallo ericdallo commented Oct 30, 2020

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@ericdallo ericdallo force-pushed the ericdallo:add-dart-to-flutter branch from cadfab0 to bee3fb8 Oct 30, 2020
@ofborg ofborg bot requested a review from babariviere Oct 30, 2020
@marsam marsam merged commit e250fef into NixOS:master Oct 30, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
flutter, flutter.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
flutter, flutter.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bee3fb8"; rev="bee3fb885fa3476fc6cd5274b1600f80bc278e51"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bee3fb8"; rev="bee3fb885fa3476fc6cd5274b1600f80bc278e51"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bee3fb8"; rev="bee3fb885fa3476fc6cd5274b1600f80bc278e51"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bee3fb8"; rev="bee3fb885fa3476fc6cd5274b1600f80bc278e51"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bee3fb8"; rev="bee3fb885fa3476fc6cd5274b1600f80bc278e51"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bee3fb8"; rev="bee3fb885fa3476fc6cd5274b1600f80bc278e51"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bee3fb8"; rev="bee3fb885fa3476fc6cd5274b1600f80bc278e51"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ericdallo ericdallo deleted the ericdallo:add-dart-to-flutter branch Oct 31, 2020
@ericdallo
Copy link
Member Author

@ericdallo ericdallo commented Oct 31, 2020

Thank you @marsam ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.