Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zulip: Don't use buildFHSUserEnvBubblewrap. #99930

Merged
merged 1 commit into from Oct 7, 2020

Conversation

@shlevy
Copy link
Member

@shlevy shlevy commented Oct 7, 2020

For as-yet unknown reasons, this causes zulip to launch with a grey screen.

See #97264 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
For as-yet unknown reasons, this causes zulip to launch with a grey screen.

See NixOS#97264 (comment)
@shlevy shlevy requested review from jonafato and Atemu Oct 7, 2020
@shlevy shlevy merged commit 558303b into NixOS:master Oct 7, 2020
19 of 20 checks passed
@shlevy shlevy deleted the zulip-no-bubblewrap branch Oct 7, 2020
@jonafato jonafato mentioned this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant