Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyqt5: 5.14.2 -> 5.15.1 #99933

Closed
wants to merge 2 commits into from
Closed

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 7, 2020

Update pyqt and sip.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar doronbehar requested review from FRidh and jonringer as code owners Oct 7, 2020
@doronbehar doronbehar changed the title ###### Motivation for this change pyqt5: 5.14.2 -> 5.15.1 Oct 7, 2020
@ofborg ofborg bot added the 6.topic: python label Oct 7, 2020
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Oct 7, 2020

This does not solve #99937

@jorsn
Copy link
Member

@jorsn jorsn commented Oct 7, 2020

This does not solve #99937

It cannot, because qt5 is overridden in pythonInterpreters.

@doronbehar doronbehar closed this Oct 8, 2020
@doronbehar doronbehar deleted the doronbehar:pkg/pyqt5/update branch Oct 8, 2020
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Oct 8, 2020

Done in #99956 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.