Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime: 0.19.0 -> 0.20.0 #99946

Merged
merged 1 commit into from Oct 8, 2020
Merged

wasmtime: 0.19.0 -> 0.20.0 #99946

merged 1 commit into from Oct 8, 2020

Conversation

@ggreif
Copy link
Contributor

@ggreif ggreif commented Oct 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ggreif
Copy link
Contributor Author

@ggreif ggreif commented Oct 7, 2020

@GrahamcOfBorg build wasmtime

Copy link
Member

@danieldk danieldk left a comment

LGTM, thanks!

Result of nixpkgs-review pr 99946 1

1 package built:
  • wasmtime

Tested the binary to work.

@danieldk danieldk merged commit c8111ef into NixOS:master Oct 8, 2020
21 checks passed
@ggreif ggreif mentioned this pull request Oct 23, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants