Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micro: 2.0.7 -> 2.0.8 #99949

Merged
merged 1 commit into from Oct 28, 2020
Merged

micro: 2.0.7 -> 2.0.8 #99949

merged 1 commit into from Oct 28, 2020

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Oct 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

goDeps = ./deps.nix;
buildFlagsArray = [ "-ldflags=-s -w -X github.com/zyedidia/micro/v2/internal/util.Version=${version} -X github.com/zyedidia/micro/v2/internal/util.CommitHash=${src.rev}" ];

This comment has been minimized.

@AndersonTorres

AndersonTorres Oct 8, 2020
Member

I am a bit curious. Are these flags something required in new versions of Go?

This comment has been minimized.

@marsam

marsam Oct 28, 2020
Author Contributor

Sorry for the late response. Golang uses -ldflags to set variable values at compile time, we use it to set the correct version string, and the -s -w helps to reduce the binary size.
These flags are not required per-se, but if we don't include them, calling micro --version doesn't show the correct version.

@marsam marsam merged commit 5b4331e into NixOS:master Oct 28, 2020
19 of 20 checks passed
19 of 20 checks passed
tests tests
Details
action
Details
micro, micro.passthru.tests on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a620816"; rev="a62081663f1530f1c12740b87368b8059f6872fd"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a620816"; rev="a62081663f1530f1c12740b87368b8059f6872fd"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a620816"; rev="a62081663f1530f1c12740b87368b8059f6872fd"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a620816"; rev="a62081663f1530f1c12740b87368b8059f6872fd"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a620816"; rev="a62081663f1530f1c12740b87368b8059f6872fd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a620816"; rev="a62081663f1530f1c12740b87368b8059f6872fd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a620816"; rev="a62081663f1530f1c12740b87368b8059f6872fd"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
micro, micro.passthru.tests on aarch64-linux Success
Details
micro, micro.passthru.tests on x86_64-linux Success
Details
@marsam marsam deleted the marsam:update-micro branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.