Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttf-tw-moe: first version #99955

Merged
merged 1 commit into from Nov 5, 2020
Merged

ttf-tw-moe: first version #99955

merged 1 commit into from Nov 5, 2020

Conversation

@Jiehong
Copy link
Contributor

@Jiehong Jiehong commented Oct 7, 2020

Motivation for this change

Add a pack of 2 fonts used as referenced for teaching in Taiwan.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Jiehong Jiehong force-pushed the feature/new_font branch from f30d147 to 5033b5d Oct 7, 2020
jiehong = {
email = "nixos@majiehong.com";
github = "Jiehong";
githubId = 42 ?;
Copy link
Contributor Author

@Jiehong Jiehong Oct 7, 2020

How do you get that value?

Copy link
Member

@pbogdan pbogdan Oct 7, 2020

You can retrieve it via API from https://api.github.com/users/Jiehong (as mentioned at the top of the file).

Copy link
Contributor Author

@Jiehong Jiehong Oct 7, 2020

@pbogdan : thanks!

@roberth
Copy link
Member

@roberth roberth commented Nov 5, 2020

Thank you @Jiehong

@roberth roberth merged commit 97e3346 into NixOS:master Nov 5, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants