Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asterisk: Bump all packages #99961

Merged
merged 1 commit into from Oct 9, 2020
Merged

asterisk: Bump all packages #99961

merged 1 commit into from Oct 9, 2020

Conversation

@dasJ
Copy link
Member

@dasJ dasJ commented Oct 7, 2020

All packages were outdated.
Asterisk 15 is not supported anymore, but there is 17 now.

All versions bumped pjproject to 2.10 which requires overriding the
prefix.

Since Asterisk 17, make install-headers seems to be needed.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
All packages were outdated.
Asterisk 15 is not supported anymore, but there is 17 now.

All versions bumped pjproject to 2.10 which requires overriding the
prefix.

Since Asterisk 17, `make install-headers` seems to be needed.
@ajs124
ajs124 approved these changes Oct 8, 2020
@DerTim1
DerTim1 approved these changes Oct 8, 2020
Copy link
Contributor

@DerTim1 DerTim1 left a comment

Great!

PR seems Ok. We may be able to test Asterisk 17 in a few weeks, but don't wait for it.

@ajs124 ajs124 merged commit 178213f into NixOS:master Oct 9, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
asterisk, asterisk.passthru.tests on aarch64-linux Success
Details
asterisk, asterisk.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5e8dbc"; rev="c5e8dbc4f1eec30f9f6858d9f8942d03ae51db65"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5e8dbc"; rev="c5e8dbc4f1eec30f9f6858d9f8942d03ae51db65"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5e8dbc"; rev="c5e8dbc4f1eec30f9f6858d9f8942d03ae51db65"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5e8dbc"; rev="c5e8dbc4f1eec30f9f6858d9f8942d03ae51db65"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5e8dbc"; rev="c5e8dbc4f1eec30f9f6858d9f8942d03ae51db65"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5e8dbc"; rev="c5e8dbc4f1eec30f9f6858d9f8942d03ae51db65"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c5e8dbc"; rev="c5e8dbc4f1eec30f9f6858d9f8942d03ae51db65"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ajs124 ajs124 deleted the helsinki-systems:upd/asterisk branch Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.