Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizon-eda: init at 1.2.1 #99964

Merged
merged 1 commit into from Oct 10, 2020
Merged

horizon-eda: init at 1.2.1 #99964

merged 1 commit into from Oct 10, 2020

Conversation

@guserav
Copy link
Contributor

@guserav guserav commented Oct 7, 2020

Mostly based on #86694 by yrashk

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Looks good. Just some minor suggestions :)

@guserav guserav force-pushed the guserav:horizon-eda branch 2 times, most recently from e179189 to 55b71e2 Oct 9, 2020
@JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Oct 9, 2020

Evaluation failure on OfBorg is unrelated. See #100089 (comment)

Tested on NixOS and seems to work fine.

Mostly based on #86694 by yrashk
@guserav guserav force-pushed the guserav:horizon-eda branch from 55b71e2 to 6a4c197 Oct 9, 2020
@JohnAZoidberg JohnAZoidberg merged commit 384470e into NixOS:master Oct 10, 2020
2 of 4 checks passed
2 of 4 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
grahamcofborg-eval The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked.
Details
@JohnAZoidberg JohnAZoidberg deleted the guserav:horizon-eda branch Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.