Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel_0: fix build on darwin #99967

Merged
merged 1 commit into from Oct 8, 2020
Merged

Conversation

@tricktron
Copy link
Contributor

@tricktron tricktron commented Oct 7, 2020

Motivation for this change

ZHF: #97479
cc: @NixOS/nixos-release-managers

Fixes error: thread-local storage is not supported for the current target by
upgrading clang_7 -> to clang_8 which supports thread-local storage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Thibault Gagnaux
Fixes `error: thread-local storage is not supported for the current target` by
upgrading clang_7 -> to clang_8 which supports thread-local storage.
@tricktron tricktron requested a review from Profpatsch as a code owner Oct 7, 2020
@ofborg ofborg bot added the 6.topic: darwin label Oct 7, 2020
@ofborg ofborg bot requested a review from mboes Oct 7, 2020
@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Oct 8, 2020

Look good, same fixes as in #100012

@Profpatsch Profpatsch merged commit fd2c495 into NixOS:master Oct 8, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
bazel_0, bazel_0.passthru.tests on aarch64-linux Success
Details
bazel_0, bazel_0.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="169998c"; rev="169998c586c6b78605ee62a04a7096f438a82dfe"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="169998c"; rev="169998c586c6b78605ee62a04a7096f438a82dfe"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="169998c"; rev="169998c586c6b78605ee62a04a7096f438a82dfe"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="169998c"; rev="169998c586c6b78605ee62a04a7096f438a82dfe"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="169998c"; rev="169998c586c6b78605ee62a04a7096f438a82dfe"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="169998c"; rev="169998c586c6b78605ee62a04a7096f438a82dfe"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="169998c"; rev="169998c586c6b78605ee62a04a7096f438a82dfe"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@tricktron tricktron mentioned this pull request Oct 10, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.