Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.nipype: disable neurdflib by default to avoid package collision #99971

Open
wants to merge 2 commits into
base: master
from

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Oct 7, 2020

Prior to this change, any closure containing python3Packages.rdflib causes a conflict with NIpype. Additionally, the patched rdflib (neurdflib) is an optional dependency of Nipype anyway (see nipy/nipype#2888) and our policy is not to include optdepends by default.

I also removed Python 2 support since Nipype doesn't support Python 2 (and python2Packages.nipype wouldn't even be attempted since dependency nibabel is disabled for that interpreter anyway).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
bcdarwin added 2 commits Oct 7, 2020
…uses a package collision when rdflib is in the closure
@bcdarwin bcdarwin requested review from FRidh and jonringer as code owners Oct 7, 2020
@ofborg ofborg bot added the 6.topic: python label Oct 7, 2020
@ofborg ofborg bot requested a review from ashgillman Oct 7, 2020
Copy link
Contributor

@drewrisinger drewrisinger left a comment

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review
3 packages built:
python37Packages.heudiconv python37Packages.nipype python38Packages.nipype
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 8, 2020

diff LGTM

I would still like to see what @FRidh thinks about the switch

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 8, 2020

https://github.com/NixOS/nixpkgs/pull/99971
3 packages built:
python37Packages.heudiconv python37Packages.nipype python38Packages.nipype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.