Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: 85.0.4183.121 -> 86.0.4240.75 #99975

Merged
merged 2 commits into from Oct 9, 2020
Merged

chromium: 85.0.4183.121 -> 86.0.4240.75 #99975

merged 2 commits into from Oct 9, 2020

Conversation

@primeos
Copy link
Member

@primeos primeos commented Oct 7, 2020

Testing status
platform attribute status tester
x86_64 chromium ✔️ @danielfullmer
x86_64 nixosTests.chromium ✔️ @danielfullmer
x86_64 google-chrome @primeos
aarch64 chromium @thefloweringash

@thefloweringash this one should be especially interesting to test on AArch64 due to the switch to LLVM 11 (no final release yet, currently at RC 6). Hope this won't cause any issues...

Note to self: I'll likely have to change the implementation of enableVaapi in the wrapper IIRC (Linux should now have a feature flag to enable it instead of disabling it - which is very nice). Not sure if I can take care of that before merging this PR due to the lack of build resources (help is welcome if someone is interested).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
primeos and others added 2 commits Oct 7, 2020
https://chromereleases.googleblog.com/2020/10/stable-channel-update-for-desktop.html

This update includes 35 security fixes.

CVEs:
CVE-2020-15967 CVE-2020-15968 CVE-2020-15969 CVE-2020-15970
CVE-2020-15971 CVE-2020-15972 CVE-2020-15990 CVE-2020-15991
CVE-2020-15973 CVE-2020-15974 CVE-2020-15975 CVE-2020-15976
CVE-2020-6557 CVE-2020-15977 CVE-2020-15978 CVE-2020-15979
CVE-2020-15980 CVE-2020-15981 CVE-2020-15982 CVE-2020-15983
CVE-2020-15984 CVE-2020-15985 CVE-2020-15986 CVE-2020-15987
CVE-2020-15992 CVE-2020-15988 CVE-2020-15989
This will additionally install the following files:
libEGL.so libGLESv2.so
libVkICD_mock_icd.so libvk_swiftshader.so libvulkan.so

libEGL.so and libGLESv2.so are required to fix our ANGLE support.
The rest should help with the Vulkan support (currently an experimental
feature that is disabled by default).
@danielfullmer
Copy link
Contributor

@danielfullmer danielfullmer commented Oct 7, 2020

Briefly tested chromium and nixosTests.chromium working on x86_64-linux.

@TredwellGit
Copy link
Contributor

@TredwellGit TredwellGit commented Oct 9, 2020

Tested chromium on x86_64 NixOS.

I got system FFmpeg 4, libjpeg, and zlib working with this. Will submit pull request after this one is merged.

@primeos
Copy link
Member Author

@primeos primeos commented Oct 9, 2020

Ok, so according to CI AArch64 should likely be fine.
I forgot to test Chrome but both M86 and M87 from the beta and dev channels where fine a few weeks ago.

M86 has (AFAIK unintentionally) enabled VA-API by default (edit: we might actually be fine due to disable-accelerated-video-decode) and I'll open another PR to disable it by default as before.

@TredwellGit thanks again for the ANGLE patch and for your testing :)

@primeos primeos merged commit 2603bd5 into NixOS:master Oct 9, 2020
19 of 20 checks passed
19 of 20 checks passed
tests tests
Details
action
Details
chromium, chromium.passthru.tests on x86_64-darwin
Details
chromium, chromium.passthru.tests on aarch64-linux Timed out, unknown build status
Details
chromium, chromium.passthru.tests on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="757bbdd"; rev="757bbdd948234710f6eabd58c80af1e7cd9bac14"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="757bbdd"; rev="757bbdd948234710f6eabd58c80af1e7cd9bac14"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="757bbdd"; rev="757bbdd948234710f6eabd58c80af1e7cd9bac14"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="757bbdd"; rev="757bbdd948234710f6eabd58c80af1e7cd9bac14"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="757bbdd"; rev="757bbdd948234710f6eabd58c80af1e7cd9bac14"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="757bbdd"; rev="757bbdd948234710f6eabd58c80af1e7cd9bac14"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="757bbdd"; rev="757bbdd948234710f6eabd58c80af1e7cd9bac14"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@primeos primeos mentioned this pull request Oct 10, 2020
0 of 10 tasks complete
@thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Oct 12, 2020

Sorry I'm a bit late. Built chromium and nixos/tests/chromium.nix -A stable on aarch64-linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.