Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] tzdata: 2019c -> 2020c #99976

Merged
merged 1 commit into from Oct 20, 2020
Merged

Conversation

@ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ajs124 ajs124 marked this pull request as ready for review Oct 7, 2020
@ajs124 ajs124 requested a review from dtzWill Oct 7, 2020
Copy link
Member

@mweinelt mweinelt left a comment

LGTM.

@ajs124 ajs124 force-pushed the helsinki-systems:upd/tzdata branch from 382ab24 to f1099d7 Oct 16, 2020
@ofborg ofborg bot requested a review from fpletz Oct 17, 2020
@ajs124 ajs124 changed the title tzdata: 2019c -> 2020b tzdata: 2019c -> 2020c Oct 17, 2020
@mweinelt mweinelt changed the title tzdata: 2019c -> 2020c [staging] tzdata: 2019c -> 2020c Oct 17, 2020
@FRidh FRidh merged commit 8904ce2 into NixOS:staging Oct 20, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1099d7"; rev="f1099d727a9e57aeec52b47cb72c51ca8bbfca0e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1099d7"; rev="f1099d727a9e57aeec52b47cb72c51ca8bbfca0e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1099d7"; rev="f1099d727a9e57aeec52b47cb72c51ca8bbfca0e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1099d7"; rev="f1099d727a9e57aeec52b47cb72c51ca8bbfca0e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1099d7"; rev="f1099d727a9e57aeec52b47cb72c51ca8bbfca0e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1099d7"; rev="f1099d727a9e57aeec52b47cb72c51ca8bbfca0e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1099d7"; rev="f1099d727a9e57aeec52b47cb72c51ca8bbfca0e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tzdata, tzdata.passthru.tests on aarch64-linux Success
Details
tzdata, tzdata.passthru.tests on x86_64-linux Success
Details
@ajs124 ajs124 deleted the helsinki-systems:upd/tzdata branch Oct 20, 2020
@ajs124
Copy link
Member Author

@ajs124 ajs124 commented Oct 22, 2020

Perfect timing, 2020d just got released.

Then again, it only moves DST in Palestine around by a week. Assuming we have any users in that timezone, they'll probably just have to live with that.

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 22, 2020

Let's just do the update and not assume where and when our users are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.