Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pydot_ng: remove #99977

merged 1 commit into from Oct 8, 2020


Copy link

@bcdarwin bcdarwin commented Oct 7, 2020

Motivation for this change

Deprecated in favour of pydot.

Things done

results of nixpkgs-review pr 99977:

3 packages removed:
python2.7-pydot_ng (\u20202.0.0) python3.7-pydot_ng (\u20202.0.0) python3.8-pydot_ng (\u20202.0.0)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@bcdarwin bcdarwin requested review from FRidh and jonringer as code owners Oct 7, 2020
- deprecated in favour of `pydot`
Copy link

@jonringer jonringer left a comment

Upstream even says repo is archived, and users are advised to use pydot

Copy link

@drewrisinger drewrisinger left a comment

  • Diff LGTM
  • Commit LGTM
  • Builds
3 packages removed:
python2.7-pydot_ng (†2.0.0) python3.7-pydot_ng (†2.0.0) python3.8-pydot_ng (†2.0.0)

@jonringer jonringer merged commit 07099cd into NixOS:master Oct 8, 2020
16 checks passed
@bcdarwin bcdarwin deleted the remove-pydot_ng branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants