Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pydot_ng: remove #99977

Merged
merged 1 commit into from Oct 8, 2020
Merged

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Oct 7, 2020

Motivation for this change

Deprecated in favour of pydot.

Things done

results of nixpkgs-review pr 99977:

 ...
3 packages removed:
python2.7-pydot_ng (\u20202.0.0) python3.7-pydot_ng (\u20202.0.0) python3.8-pydot_ng (\u20202.0.0)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bcdarwin bcdarwin requested review from FRidh and jonringer as code owners Oct 7, 2020
@ofborg ofborg bot added the 6.topic: python label Oct 7, 2020
- deprecated in favour of `pydot`
Copy link
Contributor

@jonringer jonringer left a comment

Upstream even says repo is archived, and users are advised to use pydot https://github.com/pydot/pydot-ng

Copy link
Contributor

@drewrisinger drewrisinger left a comment

  • Diff LGTM
  • Commit LGTM
  • Builds
3 packages removed:
python2.7-pydot_ng (†2.0.0) python3.7-pydot_ng (†2.0.0) python3.8-pydot_ng (†2.0.0)
@jonringer jonringer merged commit 07099cd into NixOS:master Oct 8, 2020
16 checks passed
16 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="feeb6d7"; rev="feeb6d783cd81bba1ac6f15def4b8d7ff15ec1cb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="feeb6d7"; rev="feeb6d783cd81bba1ac6f15def4b8d7ff15ec1cb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="feeb6d7"; rev="feeb6d783cd81bba1ac6f15def4b8d7ff15ec1cb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="feeb6d7"; rev="feeb6d783cd81bba1ac6f15def4b8d7ff15ec1cb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="feeb6d7"; rev="feeb6d783cd81bba1ac6f15def4b8d7ff15ec1cb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="feeb6d7"; rev="feeb6d783cd81bba1ac6f15def4b8d7ff15ec1cb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="feeb6d7"; rev="feeb6d783cd81bba1ac6f15def4b8d7ff15ec1cb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bcdarwin bcdarwin deleted the bcdarwin:remove-pydot_ng branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.