Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.taskwhisperer: 12 -> 16, unbreak #99985

Merged
merged 1 commit into from Oct 11, 2020

Conversation

@jonafato
Copy link
Contributor

@jonafato jonafato commented Oct 7, 2020

Motivation for this change

taskwhisperer has a new release that supports GNOME 3.36 and 3.38. Full changelog available at cinatic/taskwhisperer@v12...v16.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
taskwhisperer has a new release that supports GNOME 3.36 and 3.38. Full
changelog available at
cinatic/taskwhisperer@v12...v16.
@jonafato jonafato force-pushed the jonafato:gnomeExtensions.taskwhisperer-15 branch from bc3dc74 to b74c863 Oct 8, 2020
@jonafato jonafato changed the title gnomeExtensions.taskwhisperer: 12 -> 15, unbreak gnomeExtensions.taskwhisperer: 12 -> 16, unbreak Oct 8, 2020
@jonafato jonafato marked this pull request as ready for review Oct 8, 2020
@jonafato jonafato requested a review from bjornfor Oct 8, 2020
@jonafato
Copy link
Contributor Author

@jonafato jonafato commented Oct 8, 2020

Updated this PR due to a new version being released with a 3.38 fix. @bjornfor same change, just version 16 instead of 15.

@bjornfor bjornfor merged commit 1314788 into NixOS:master Oct 11, 2020
2 of 4 checks passed
2 of 4 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
grahamcofborg-eval The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked.
Details
@jonafato jonafato deleted the jonafato:gnomeExtensions.taskwhisperer-15 branch Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.