Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: 0.115.6 -> 0.116.2; python3Packages.voluptuous: 0.11.7 -> 0.12.0; pythonPackages.yeelight: 0.5.3 -> 0.5.4 #99986

Merged
merged 7 commits into from Oct 9, 2020

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 7, 2020

Motivation for this change

New upstream release. Bumped voluptuous, since they required a newer version released two weeks ago.

Also enabled parallel testing using xdist, which cuts down the testPhase by a large margin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mweinelt mweinelt requested review from FRidh and jonringer as code owners Oct 7, 2020
@ofborg ofborg bot added the 6.topic: python label Oct 7, 2020
@ofborg ofborg bot requested review from dotlambda, globin and Mic92 Oct 7, 2020
@mweinelt mweinelt force-pushed the mweinelt:hass branch 3 times, most recently from 6ae44c0 to 3550940 Oct 8, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
if you don't want to rewrite the test logic, then thats all good :)

https://github.com/NixOS/nixpkgs/pull/99986
27 packages built:
appdaemon elasticsearch-curator esphome home-assistant python27Packages.voluptuous python37Packages.async-upnp-client python37Packages.bellows python37Packages.pyhs100 python37Packages.voluptuous python37Packages.voluptuous-serialize python37Packages.zha-quirks python37Packages.zigpy python37Packages.zigpy-cc python37Packages.zigpy-deconz python37Packages.zigpy-xbee python37Packages.zigpy-zigate python38Packages.async-upnp-client python38Packages.bellows python38Packages.pyhs100 python38Packages.voluptuous python38Packages.voluptuous-serialize python38Packages.zha-quirks python38Packages.zigpy python38Packages.zigpy-cc python38Packages.zigpy-deconz python38Packages.zigpy-xbee python38Packages.zigpy-zigate
pkgs/servers/home-assistant/default.nix Outdated Show resolved Hide resolved
@mweinelt mweinelt force-pushed the mweinelt:hass branch from 3550940 to 4e14804 Oct 8, 2020
@mweinelt mweinelt changed the title home-assistant: 0.115.6 -> 0.116.0; python3Packages.voluptuous: 0.11.7 -> 0.12.0 home-assistant: 0.115.6 -> 0.116.1; python3Packages.voluptuous: 0.11.7 -> 0.12.0 Oct 8, 2020
mweinelt added 5 commits Oct 7, 2020
Enable tests by running nosetests during checkPhase.
Enables testing in parallel. This cuts down the test phase from over
five to under one minute on my 6C/12T processor.

Sadly while the upstream runs their tests using `-n auto` this isn't
working for us in all cases. I currently assume they use low concurrency in
their CI, which is not triggering these issues..
@mweinelt mweinelt force-pushed the mweinelt:hass branch from df60021 to 9451512 Oct 9, 2020
@mweinelt mweinelt changed the title home-assistant: 0.115.6 -> 0.116.1; python3Packages.voluptuous: 0.11.7 -> 0.12.0 home-assistant: 0.115.6 -> 0.116.2; python3Packages.voluptuous: 0.11.7 -> 0.12.0 Oct 9, 2020
@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Oct 9, 2020

And https://github.com/home-assistant/core/releases/tag/0.116.2.

I'll merge this after @GrahamcOfBorg confirms all well, else we're gonna stack more updates. They're coming fast these days.

Use pytestCheckhook for testing.
@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Oct 9, 2020

Result of nixpkgs-review pr 99986 1

30 packages built:
  • appdaemon
  • elasticsearch-curator
  • esphome
  • home-assistant
  • python27Packages.voluptuous
  • python27Packages.yeelight
  • python37Packages.async-upnp-client
  • python37Packages.bellows
  • python37Packages.pyhs100
  • python37Packages.voluptuous
  • python37Packages.voluptuous-serialize
  • python37Packages.yeelight
  • python37Packages.zha-quirks
  • python37Packages.zigpy
  • python37Packages.zigpy-cc
  • python37Packages.zigpy-deconz
  • python37Packages.zigpy-xbee
  • python37Packages.zigpy-zigate
  • python38Packages.async-upnp-client
  • python38Packages.bellows
  • python38Packages.pyhs100
  • python38Packages.voluptuous
  • python38Packages.voluptuous-serialize
  • python38Packages.yeelight
  • python38Packages.zha-quirks
  • python38Packages.zigpy
  • python38Packages.zigpy-cc
  • python38Packages.zigpy-deconz
  • python38Packages.zigpy-xbee
  • python38Packages.zigpy-zigate
@mweinelt mweinelt merged commit 81b664a into NixOS:master Oct 9, 2020
2 of 3 checks passed
2 of 3 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@mweinelt mweinelt changed the title home-assistant: 0.115.6 -> 0.116.2; python3Packages.voluptuous: 0.11.7 -> 0.12.0 home-assistant: 0.115.6 -> 0.116.2; python3Packages.voluptuous: 0.11.7 -> 0.12.0; pythonPackages.yeelight: 0.5.3 -> 0.5.4 Oct 9, 2020
@mweinelt mweinelt deleted the mweinelt:hass branch Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.