Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm2: init at 4.5.0 #99992

Merged
merged 1 commit into from Oct 13, 2020
Merged

pm2: init at 4.5.0 #99992

merged 1 commit into from Oct 13, 2020

Conversation

@jeremyschlatter
Copy link
Contributor

@jeremyschlatter jeremyschlatter commented Oct 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@aanderse
Copy link
Member

@aanderse aanderse commented Oct 8, 2020

See #86840 and #99617.

@jeremyschlatter jeremyschlatter force-pushed the pm2 branch 2 times, most recently from f89b687 to fc94fbd Oct 8, 2020
@jeremyschlatter jeremyschlatter changed the title nodePackages.pm2: init at 4.5.0 pm2: init at 4.5.0 Oct 8, 2020
@jeremyschlatter
Copy link
Contributor Author

@jeremyschlatter jeremyschlatter commented Oct 8, 2020

Whoops, I didn't notice those other pm2 PRs when I opened this. Thanks for linking them.

Tempted to close this one, but I'll leave it open for now in case it's easier to merge. (The other two currently have merge conflicts.)

@jeremyschlatter
Copy link
Contributor Author

@jeremyschlatter jeremyschlatter commented Oct 13, 2020

@jtojnar Would you be up for reviewing this?

I'm still learning how the review process works around here. 😅 I've had a couple of packages merged so far, but the people who merged them showed up by magic and I don't know who to ask for help when that doesn't happen.

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 13, 2020

There is not really much to review. Let’s just merge this before there are conflicts again.

@jtojnar jtojnar merged commit 22ac861 into NixOS:master Oct 13, 2020
19 checks passed
@jtojnar jtojnar mentioned this pull request Oct 13, 2020
10 tasks
@jtojnar jtojnar mentioned this pull request Oct 13, 2020
10 tasks
@jtojnar jtojnar mentioned this pull request Oct 13, 2020
@jeremyschlatter jeremyschlatter deleted the pm2 branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants