Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fujprog: 4.6 -> 4.8 #99995

Merged
merged 2 commits into from Oct 12, 2020
Merged

fujprog: 4.6 -> 4.8 #99995

merged 2 commits into from Oct 12, 2020

Conversation

@trepetti
Copy link
Contributor

@trepetti trepetti commented Oct 8, 2020

Motivation for this change

Some fixes related to MacOS and packaging conventions and a version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@trepetti
Copy link
Contributor Author

@trepetti trepetti commented Oct 8, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 8, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 8, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

Copy link
Contributor

@drewrisinger drewrisinger left a comment

  • Diff LGTM
  • Builds via nix-review on x86_64-linux
  • Commits LGTM. Could be squashed, but up to merger.
  • Don't have Mac/Darwin machine to test this on.

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Oct 8, 2020

/status needs_reviewer
Needs Darwin reviewer/tester

Copy link
Member

@danieldk danieldk left a comment

Thanks, looks good. One requested change.

pkgs/development/tools/misc/fujprog/default.nix Outdated Show resolved Hide resolved
@trepetti
Copy link
Contributor Author

@trepetti trepetti commented Oct 10, 2020

@ofborg eval

@trepetti
Copy link
Contributor Author

@trepetti trepetti commented Oct 10, 2020

pkgs/development/tools/misc/fujprog/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@danieldk danieldk left a comment

LGTM. Tested on Darwin.

@danieldk danieldk requested a review from marsam Oct 12, 2020
marsam
marsam approved these changes Oct 12, 2020
@marsam marsam merged commit 166bbe9 into NixOS:master Oct 12, 2020
19 checks passed
@trepetti trepetti deleted the fujprog-4.8 branch Oct 12, 2020
@trepetti trepetti mentioned this pull request Oct 14, 2020
10 tasks
@r-burns r-burns mentioned this pull request Oct 25, 2020
10 tasks
@trepetti trepetti mentioned this pull request Mar 3, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants