Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unison-ucm: add less to buildInputs #99996

Closed
wants to merge 1 commit into from
Closed

Conversation

@ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Oct 8, 2020

Motivation for this change

less is used by ucm. This has probably gone unnoticed since less
is usually available, but it fails when using a nix-shell with --pure.

Things done

Add less to buildInputs of unison-ucm.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
`less` is used by `ucm`. This has probably gone unnoticed since `less`
is usually available, but it fails when using a nix-shell with `--pure`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant