Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octoprint: assorted plugin maintenance #99998

merged 3 commits into from Oct 11, 2020


Copy link

@lovesegfault lovesegfault commented Oct 8, 2020

Motivation for this change

This was done while I was working on #98917, but didn't fit in that PR. I noticed a couple of the octoprint plugins were out of date, so I bumped them, and in the process added a new plugin that I need.

All were tested and work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@IvarWithoutBones IvarWithoutBones left a comment

LGTM except for 1 minor problem.

pkgs/applications/misc/octoprint/plugins.nix Outdated Show resolved Hide resolved
Copy link

@j0hax j0hax commented Oct 8, 2020

Thanks for updating so quickly.

Unfortunately my previous commits (#99010) have been open for over a week now.

@j0hax j0hax mentioned this pull request Oct 8, 2020
10 tasks
@lovesegfault lovesegfault force-pushed the octoprint-plugin-bump branch from e0b9ede to a742a83 Oct 9, 2020
Copy link
Member Author

@lovesegfault lovesegfault commented Oct 9, 2020

cc. @andir for a final review / landing

@lovesegfault lovesegfault requested a review from andir Oct 9, 2020
Copy link

@gebner gebner commented Oct 11, 2020

Thanks! Evaluation error is unrelated.

@gebner gebner merged commit f780534 into NixOS:master Oct 11, 2020
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants