Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
add label for exactly 1 rebuild #395
It is fundamentally different to review a leaf package with no other reverse dependencies in Nixpkgs and one that has at least one reverse dependency, so make those separate labels.
I expect rolling this out is going to have to coincide with updating the labels and adding the new labels.
@grahamc Okay, done, and I added the proper tests now. Also, your suggestion makes this change will be backward compatible, so that's nice!
By the way, I didn't commit this but in order to build this I had to add the
If you want me to add those
Please do add the annotations :)…
On Thu, Sep 26, 2019, at 12:52 AM, Ryan Mulligan wrote: @grahamc <https://github.com/grahamc> Okay, done, and I added the proper tests now. Also, your suggestion makes this change will be backward compatible, so that's nice! By the way, I didn't commit this but in order to build this I had to add the `dyn` annotation in 7 places because of this error: `error: trait objects without an explicit `dyn` are deprecated` If you want me to add those `dyn` annotations to this branch, I can. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#395?email_source=notifications&email_token=AAASXLFYWQ3J2O56PE2XWJLQLQ5XRA5CNFSM4ITBHPA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7UI5DA#issuecomment-535334540>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAASXLGOPMLE7ANAK77CZNLQLQ5XRANCNFSM4ITBHPAQ>.