Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add label for exactly 1 rebuild #395

Open
wants to merge 2 commits into
base: released
from

Conversation

@ryantm
Copy link
Member

commented Sep 3, 2019

It is fundamentally different to review a leaf package with no other reverse dependencies in Nixpkgs and one that has at least one reverse dependency, so make those separate labels.

I expect rolling this out is going to have to coincide with updating the labels and adding the new labels.

@ryantm ryantm force-pushed the ryantm:leaf branch from 8c76010 to 0dab92a Sep 3, 2019
@grahamc

This comment has been minimized.

Copy link
Member

commented Sep 19, 2019

This is a good idea. I'd like to continue applying the 1-10 label in the 1 case, so existing searches continue to work.

It is fundamentally different to review a leaf package with no other
reverse dependencies in Nixpkgs and one that has at least one reverse
dependency, so make those separate labels.
@ryantm ryantm force-pushed the ryantm:leaf branch from 0dab92a to 88b2c5e Sep 26, 2019
@ryantm

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2019

@grahamc Okay, done, and I added the proper tests now. Also, your suggestion makes this change will be backward compatible, so that's nice!

By the way, I didn't commit this but in order to build this I had to add the dyn annotation in 7 places because of this error:

error: trait objects without an explicit dyn are deprecated

If you want me to add those dyn annotations to this branch, I can.

@grahamc

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

@ryantm

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2019

@grahamc Added.

@ryantm

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2019

@grahamc Do you need anything else from me to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.