Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip stdenv rebuilds #481

Open
wants to merge 1 commit into
base: released
from
Open

skip stdenv rebuilds #481

wants to merge 1 commit into from

Conversation

@LnL7
Copy link
Member

@LnL7 LnL7 commented May 5, 2020

Before attempting builds check if the stdenv for this branch is
available in the cache. If this is not the case then either the merge
request is a mass rebuild or it's targeting a branch like staging.

Before attempting builds check if the stdenv for this branch is
available in the cache.  If this is not the case then either the merge
request is a mass rebuild or it's targeting a branch like staging.
info!("Checking for stdenv rebuild");
let in_cache = self
.nix
.safely_query_cache_for_attr(refpath.as_ref(), buildfile, "stdenv".to_string())

This comment has been minimized.

@cole-h

cole-h May 5, 2020
Member

Nit, but I prefer String::from() over to_string() for static strings like this.

(Though AFAICT they are the same; personal preference, really.)

Suggested change
.safely_query_cache_for_attr(refpath.as_ref(), buildfile, "stdenv".to_string())
.safely_query_cache_for_attr(refpath.as_ref(), buildfile, String::from("stdenv"))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.