Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Not you: team." (Rework README) #482

Merged
merged 3 commits into from May 20, 2020
Merged

"Not you: team." (Rework README) #482

merged 3 commits into from May 20, 2020

Conversation

@cole-h
Copy link
Member

cole-h commented May 6, 2020

Some of the information in the README is outdated, such as the sections
detailing the privileges of known users (everybody is now a known user).
The only distinction made is between that of trusted users and everybody
else. Trusted users gain an additional host to run builds and tests on:
x86_64-darwin. Everybody else is locked to x86_64-linux and
aarch64-linux.

With the removal of all mentions of "known users", the
config.{extra-,}known-users.json files have also been removed. This
change will require coordination with the infrastructure repo [1] --
namely, a PR removing references to these files (otherwise, I imagine,
deploys will fail).

Something Graham has mentioned a few times is how he wants to decouple
ofborg from his persona. Thus, @ofborg is now used in place of
@GrahamcOfBorg everywhere possible (it is still possible to use
@GrahamcOfBorg, so it has not been removed from the codebase at this
time).

[1] https://github.com/ofborg/infrastructure


Thanks to @sorki, there is now a Hacking section that details a
quick-and-dirty way to get started with working on ofborg's internals.

Depends on ofborg/infrastructure#21.

Closes #445.

EDIT: I've removed the "Running a Build" section from the README and placed its contents in the Wiki: https://github.com/NixOS/ofborg/wiki/Operating-a-Builder/

@grahamc
grahamc approved these changes May 6, 2020
Copy link
Member

grahamc left a comment

Yes! Thank you! (cc @andir for title.)

@cole-h cole-h force-pushed the cole-h:not-you-team branch from 8b7ff41 to a1e64cb May 6, 2020
@cole-h cole-h requested a review from grahamc May 6, 2020
@cole-h cole-h force-pushed the cole-h:not-you-team branch 4 times, most recently from 80b12e2 to 0b18420 May 7, 2020
@cole-h cole-h force-pushed the cole-h:not-you-team branch from 0b18420 to 5b3e65f May 16, 2020
sorki and others added 3 commits Apr 12, 2020
Co-Authored-By: Cole Helbling <cole.e.helbling@outlook.com>
Some of the information in the README is outdated, such as the sections
detailing the privileges of known users (everybody is now a known user).
The only distinction made is between that of trusted users and everybody
else. Trusted users gain an additional host to run builds and tests on:
x86_64-darwin. Everybody else is locked to x86_64-linux and
aarch64-linux.

With the removal of all mentions of "known users", the
`config.{extra-,}known-users.json` files have also been removed. This
change will require coordination with the infrastructure repo [1] --
namely, a PR removing references to these files (otherwise, I imagine,
deploys will fail).

Something Graham has mentioned a few times is how he wants to decouple
ofborg from his persona. Thus, `@ofborg` is now used in place of
`@GrahamcOfBorg` everywhere possible (it is still possible to use
`@GrahamcOfBorg`, so it has not been removed from the codebase at this
time).

[1] https://github.com/ofborg/infrastructure
@cole-h cole-h force-pushed the cole-h:not-you-team branch from 7399892 to 31e7100 May 16, 2020
@cole-h cole-h merged commit bf3e5db into NixOS:released May 20, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cole-h cole-h deleted the cole-h:not-you-team branch May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.