Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce info logging #486

Merged
merged 1 commit into from May 19, 2020
Merged

reduce info logging #486

merged 1 commit into from May 19, 2020

Conversation

@LnL7
Copy link
Member

LnL7 commented May 12, 2020

No description provided.

Copy link
Member

cole-h left a comment

Minor nits (I love me some proper capitalization).

ofborg/src/tasks/build.rs Outdated Show resolved Hide resolved
ofborg/src/tasks/evaluate.rs Outdated Show resolved Hide resolved
@@ -118,7 +118,7 @@ impl CachedProjectCo {
pub fn commit_exists(&self, commit: &OsStr) -> bool {
let mut lock = self.lock().expect("Failed to lock");

info!("Checking if commit '{:?}' exists", commit);

This comment has been minimized.

Copy link
@cole-h

cole-h May 12, 2020

Member

Thanks, been meaning to fix those, but never got around to it. (Who knew: the debug representation of strings and string-likes are quoted, making single-quotes noisy and unnecessary!)

@LnL7 LnL7 force-pushed the LnL7:log-cleanup branch from c04cf10 to d7062d1 May 12, 2020
@cole-h
cole-h approved these changes May 12, 2020
@LnL7 LnL7 merged commit bb3c29c into NixOS:released May 19, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@LnL7 LnL7 deleted the LnL7:log-cleanup branch May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.