Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lapin evaluation filter #491

Merged
merged 2 commits into from May 21, 2020
Merged

lapin evaluation filter #491

merged 2 commits into from May 21, 2020

Conversation

@LnL7
Copy link
Member

LnL7 commented May 21, 2020

No description provided.

LnL7 added 2 commits May 21, 2020
@cole-h
cole-h approved these changes May 21, 2020
@LnL7 LnL7 merged commit b7a8808 into NixOS:released May 21, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@LnL7 LnL7 deleted the LnL7:lapin-evaluation-filter branch May 21, 2020
chan.bind_queue(easyamqp::BindQueueConfig {
queue: queue_name.clone(),
exchange: "github-events".to_owned(),
routing_key: Some("pull_request.nixos/nixpkgs".to_owned()),
no_wait: false,
})?;
Comment on lines +52 to +57

This comment has been minimized.

Copy link
@grahamc

grahamc May 22, 2020

Member

This change is binding mass-rebuild-check-jobs to subscribe directly to github-events, where mass-rebuild-check-inputs should be binding to github-events and then this task writes the filtered tasks to the jobs queue.

This comment has been minimized.

Copy link
@cole-h

cole-h May 22, 2020

Member

Good catch, sorry I missed that.

This comment has been minimized.

Copy link
@LnL7

LnL7 May 22, 2020

Author Member

These kind of subtile bugs are also really hard to catch during review if you're not looking for something specific.

@grahamc
Copy link
Member

grahamc commented May 22, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.