Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax PullRequestAction parsing #497

Merged
merged 1 commit into from May 23, 2020
Merged

Conversation

@LnL7
Copy link
Member

LnL7 commented May 23, 2020

Unknown events are fine here, as long as it's a valid event continue and
consider it not interesting instead.

Should alleviate fixes like #496 in the future.

Unknown events are fine here, as long as it's a valid event continue and
consider it not interesting instead.

Should alleviate fixes like #496 in the future.
@cole-h
cole-h approved these changes May 23, 2020
Copy link
Member

cole-h left a comment

What's the reason for dropping the other variants? Is it because they are currently unused?

@LnL7
Copy link
Member Author

LnL7 commented May 23, 2020

Yeah they where there for the same reason as ConvertToDraft, if we ever want to use specific actions they can be added back. For example with skipping builds for draft pull requests making the pr as ready should trigger builds.

@LnL7 LnL7 merged commit d9dccbc into NixOS:released May 23, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@LnL7 LnL7 deleted the LnL7:relax-ghevent-parsing branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.