Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lapin: 1.0.0-beta4 -> 1.0.0-rc6 #498

Closed
wants to merge 2 commits into from
Closed

lapin: 1.0.0-beta4 -> 1.0.0-rc6 #498

wants to merge 2 commits into from

Conversation

@LnL7
Copy link
Member

LnL7 commented May 23, 2020

No description provided.

LnL7 added 2 commits May 23, 2020
CloseOnDrop was removed so channels can be used directly now.
@cole-h
cole-h approved these changes May 24, 2020
Copy link
Member

cole-h left a comment

LGTM once you get CI to pass.

I am curious why CloseOnDrop is being... well, dropped, though. Was it a workaround for something that has been fixed in one of the versions since beta4?

@LnL7
Copy link
Member Author

LnL7 commented May 24, 2020

It's a new api change for 1.0. From what I can tell auto closing is now internal, making the types a bit nicer to work with.

@LnL7 LnL7 mentioned this pull request May 24, 2020
@LnL7
Copy link
Member Author

LnL7 commented May 24, 2020

I'll open another pr with a cargo update once crate2nix has been merged.

@LnL7 LnL7 closed this May 24, 2020
@LnL7 LnL7 deleted the LnL7:lapin-update branch May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.