Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplapin: 1.0.0-beta4 -> 1.0.0-rc6 #498
Closed
Conversation
|
LGTM once you get CI to pass. I am curious why |
|
It's a new api change for 1.0. From what I can tell auto closing is now internal, making the types a bit nicer to work with. |
Merged
|
I'll open another pr with a cargo update once crate2nix has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
LnL7 commentedMay 23, 2020
No description provided.