Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements #235

Open
wants to merge 8 commits into
base: master
from
Open

minor improvements #235

wants to merge 8 commits into from

Conversation

@DerDakon
Copy link
Contributor

@DerDakon DerDakon commented Sep 4, 2020

Just some things I came accross while hacking on some custom ELF manipulations.

@domenkozar domenkozar requested a review from edolstra Sep 8, 2020
@DerDakon DerDakon force-pushed the emlix:cleanups branch 2 times, most recently from ac13b5b to dc7bb23 Sep 16, 2020
DerDakon added 7 commits Sep 4, 2020
../../patchelf/src/patchelf.cc:835:19: warning: comparison of integer expressions of different signedness: 'long long unsigned int' and 'off_t' {aka 'long long int'} [-Wsign-compare]
  835 |     assert(curOff == startOffset + neededSpace);
      |            ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
@DerDakon DerDakon force-pushed the emlix:cleanups branch from dc7bb23 to 8f47519 Sep 18, 2020
@DerDakon DerDakon force-pushed the emlix:cleanups branch from 8f47519 to ef4bff5 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.