Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option --add-rpath #246

Merged
merged 3 commits into from Aug 5, 2021
Merged

Added option --add-rpath #246

merged 3 commits into from Aug 5, 2021

Conversation

@xavierabellan
Copy link
Contributor

@xavierabellan xavierabellan commented Oct 5, 2020

New option --add-rpath makes it possible to just add a new entry to the rpath list preserving the existing ones in one operation. This avoids having to run patchelf --print-rpath, save the current value in a variable, append the new path to the variable and then patchelf --set-rpath.

@domenkozar domenkozar requested a review from edolstra Oct 5, 2020
src/patchelf.cc Show resolved Hide resolved
Mic92
Mic92 approved these changes Nov 26, 2020
Copy link
Member

@Mic92 Mic92 left a comment

The option makes the tool easier to use and its test should cover all cases.

@domenkozar domenkozar merged commit dab4411 into NixOS:master Aug 5, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants