-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC 0010] Nixpkgs development support #10
Conversation
0a08883
to
8a17014
Compare
This sounds like it could easily become a dumping ground of random crap. What would be the inclusion criteria? The alternative - using separate repositories - seems fine for development since people can use Also, I'm afraid |
I'm reluctant to assume the availability of We don't have explicit inclusion criteria elsewhere in nixpkgs, do we? It should be something generally usefuil and maintainable and up to basic standards of code cleanliness. Alternate repositories can't be kept in tight lockstep with nixpkgs. This is why we have nixos in nixpkgs, right?
|
Another issue: How does this differ from |
Any tool relying on `builtins.exec` will take that function as an | ||
argument, rather than using the builtin directly, so that all of | ||
nixpkgs evaluates properly without | ||
`allow-unsafe-native-code-during-evaluation`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why this is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes it possible with a grep (possibly even enforced before merging) that nothing you build in nixpkgs can cause a problem if you have allow-unsafe-native-code-during-evaluation
on.
# Detailed design | ||
[design]: #detailed-design | ||
|
||
Add `pkgs/development-support`, add `pkgs.development-support` calling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-> pkgs.developmentSupport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, fixing
@edolstra |
I think it's partly about discoverability and partly about co-versioned-ness. In many ways the closer analog to what you're talking about feels like the maintainers folder and possibly @aszlig's md5 collision abomination. These both strongly suggest to me that we want tooling for working on the nixpkgs repo, and want many of the goodies that Nix provides when working on Nixpkgs itself |
@copumpkin Want to coauthor? |
Created https://github.com/shlevy/nixpkgs-development-support for now |
developers who use nix to manage their projects. With the merging of | ||
the `builtins.exec` nix feature, there are a number of developer tools | ||
I'd like to make widely available, such as something to translate a | ||
.gitignore into a filterSource call or do no-sha256 fetchgit with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Another feature I would not want to see. Others have given enough arguments already. |
Rendered: https://github.com/shlevy/rfcs/blob/nixpkgs-development-support/rfcs/0010-nixpkgs-development-support.md