Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Fix find reqs args #14

Merged
merged 2 commits into from Oct 26, 2016
Merged

Fix find reqs args #14

merged 2 commits into from Oct 26, 2016

Conversation

SamGerber-zz
Copy link
Contributor

@SamGerber-zz SamGerber-zz commented Oct 26, 2016

Renamed the script, made it executable, and changed the arg parser so it should work with the asset-dir

@@ -60,8 +60,8 @@ def main():

# example 'app/assets/javascripts/teach/course-creation-component.js.coffee'
parser.add_argument('filename', help='The file to use for starting the requirement search')
parser.add_argument('--asset-dir', dest='asset_dir', const='./', default='./', action='store', nargs='?', help='Asset dir to look into')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 right you are! that's what I get for rushing things!

@eeue56
Copy link
Contributor

eeue56 commented Oct 26, 2016

@SamGerber looks good to me! please:

  • merge this commit
  • add a new tag bumping to 3.0.0
  • update deploy/asset_dependencies.sh to use 3.0.0

Thanks!

@SamGerber-zz SamGerber-zz merged commit 83b8010 into master Oct 26, 2016
@SamGerber-zz SamGerber-zz deleted the fix-find-reqs-args branch October 26, 2016 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants