access_token to external login by provider #161

Merged
merged 7 commits into from Nov 26, 2011

Conversation

Projects
None yet
4 participants
Contributor

rafaelsachetto commented Nov 26, 2011

support to get access token of external login, new external method access_token added

Contributor

rafaelsachetto commented Nov 26, 2011

Sorry about the commit trash, I forgot the other clients and after cleaning a space code, I tried the amend but it was not a good idea.

@NoamB NoamB added a commit that referenced this pull request Nov 26, 2011

@NoamB NoamB Merge pull request #161 from rafaelsachetto/master
access_token to external login by provider
daaeefc

@NoamB NoamB merged commit daaeefc into NoamB:master Nov 26, 2011

Owner

NoamB commented Nov 26, 2011

Thanks.

I think, this is wrong, very wrong. You add access_token to class methods but access_token sholud be only for user instance! When you login on firefox to your aplication and show access_token, and next you go to your site on another browser (not logged in) you can see your token.
Another thing is, that if you are logged in, and next you restart your application your access_token will be nil.
What is your opinion on this?

Contributor

rafaelsachetto replied Jan 13, 2012

Any idea how to get the access token of the instance? I noticed this error as well but decided to rush in putting the token in a session once logged in (the project was timely and no longer active)

This is my solution przemad/sorcery@8c9c5a8
I try to prepare pull request in this weekend to fix this. There is no test for this yet :/

Collaborator

willywg commented on e6e6912 Mar 20, 2012

This method currently dont work fine... This get a OAuth2::AccessToken object .... don't the access_token value... You can fix that change @provider.access_token.token

cc: @rafaelsachetto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment