fix: #7826, fix order of categories on recent dropdown

NodeBB · Aug 8, 2019 · 3ecac97 · 3ecac97
1 parent cbede89
commit 3ecac97
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/controllers/helpers.js b/src/controllers/helpers.js
@@ -273,7 +273,7 @@ function getCategoryData(cids, uid, selectedCid, callback) {
 	}
 	async.waterfall([
 		function (next) {
-			categories.getCategoriesFields(cids, ['cid', 'name', 'slug', 'icon', 'link', 'color', 'bgColor', 'parentCid', 'image', 'imageClass'], next);
+			categories.getCategoriesFields(cids, ['cid', 'order', 'name', 'slug', 'icon', 'link', 'color', 'bgColor', 'parentCid', 'image', 'imageClass'], next);
 		},
 		function (categoryData, next) {
 			categoryData = categoryData.filter(category => category && !category.link);

diff --git a/src/user/categories.js b/src/user/categories.js
@@ -49,9 +49,9 @@ module.exports = function (User) {
 		if (!(parseInt(uid, 10) > 0)) {
 			return await categories.getAllCidsFromSet('categories:cid');
 		}
-		const userState = await User.getCategoryWatchState(uid);
-		const cids = Object.keys(userState);
-		return cids.filter(cid => states.includes(userState[cid]));
+		const cids = await categories.getAllCidsFromSet('categories:cid');
+		const userState = await categories.getWatchState(cids, uid);
+		return cids.filter((cid, index) => states.includes(userState[index]));
 	};
 
 	User.ignoreCategory = async function (uid, cid) {