diff --git a/public/src/admin/manage/users.js b/public/src/admin/manage/users.js index ebd23da5fc1f..4776a9bad6cb 100644 --- a/public/src/admin/manage/users.js +++ b/public/src/admin/manage/users.js @@ -353,16 +353,15 @@ define('admin/manage/users', ['translator', 'benchpress', 'autocomplete'], funct password: password, }; - socket.emit('admin.user.createUser', user, function (err) { - if (err) { - return errorEl.translateHtml('[[admin/manage/users:alerts.error-x, ' + err.message + ']]').removeClass('hide'); - } - + $.post(config.relative_path + '/api/v1/users', user).done(function () { modal.modal('hide'); modal.on('hidden.bs.modal', function () { ajaxify.refresh(); }); app.alertSuccess('[[admin/manage/users:alerts.create-success]]'); + }).fail(function () { + console.log(arguments); + // return errorEl.translateHtml('[[admin/manage/users:alerts.error-x, ' + err.message + ']]').removeClass('hide'); }); } diff --git a/public/src/sockets.js b/public/src/sockets.js index 0d2c61dc1de3..a5b087222cac 100644 --- a/public/src/sockets.js +++ b/public/src/sockets.js @@ -72,6 +72,9 @@ socket = window.socket; socket.on('event:alert', function (params) { app.alert(params); }); + socket.on('event:deprecated_call', function (data) { + console.warn('[socket.io] ', data.eventName, 'is now deprecated in favour of', data.replacement); + }); socket.removeAllListeners('event:nodebb.ready'); socket.on('event:nodebb.ready', function (data) { diff --git a/src/socket.io/admin/user.js b/src/socket.io/admin/user.js index fa698301e4c1..b458d4fcbe98 100644 --- a/src/socket.io/admin/user.js +++ b/src/socket.io/admin/user.js @@ -11,6 +11,7 @@ const meta = require('../../meta'); const plugins = require('../../plugins'); const translator = require('../../translator'); const flags = require('../../flags'); +const sockets = require('..'); const User = module.exports; @@ -57,6 +58,8 @@ User.removeAdmins = async function (socket, uids) { }; User.createUser = async function (socket, userData) { + sockets.warnDeprecated(socket, 'POST /api/v1/users'); + if (!userData) { throw new Error('[[error:invalid-data]]'); } diff --git a/src/socket.io/index.js b/src/socket.io/index.js index 50c116d71beb..3090019fa711 100644 --- a/src/socket.io/index.js +++ b/src/socket.io/index.js @@ -258,3 +258,10 @@ Sockets.reqFromSocket = function (socket, payload, event) { headers: headers, }; }; + +Sockets.warnDeprecated = (socket, replacement) => { + socket.emit('event:deprecated_call', { + eventName: socket.previousEvents[socket.previousEvents.length - 1], + replacement: replacement, + }); +};