From 8887f0edaa1b06de633f3135c95bf66fdba7c05c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Fri, 7 Aug 2020 18:57:40 -0400
Subject: [PATCH] fix: don't allow duplicate upgrade script names

---
 src/upgrade.js | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/src/upgrade.js b/src/upgrade.js
index f85ca13f19a0..7c1563bd0e9d 100644
--- a/src/upgrade.js
+++ b/src/upgrade.js
@@ -41,6 +41,23 @@ Upgrade.getAll = function (callback) {
 			}));
 		},
 		async.apply(Upgrade.appendPluginScripts),
+		function (files, next) {
+			// check duplicates and error
+			const seen = {};
+			const dupes = [];
+			files.forEach((file) => {
+				if (seen[file]) {
+					dupes.push(file);
+				} else {
+					seen[file] = true;
+				}
+			});
+			if (dupes.length) {
+				winston.error('Found duplicate upgrade scripts\n' + dupes);
+				return next(new Error('[[error:duplicate-upgrade-scripts]]'));
+			}
+			setImmediate(next);
+		},
 	], callback);
 };