From f1974fb90001a41e26ad3ad4ed944577a195668b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Wed, 29 Jul 2020 21:48:31 -0400
Subject: [PATCH] refactor: pass only needed data

---
 src/groups/search.js    | 1 -
 src/socket.io/groups.js | 7 +++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/groups/search.js b/src/groups/search.js
index 862be73185a8..cab203b9b3b0 100644
--- a/src/groups/search.js
+++ b/src/groups/search.js
@@ -58,7 +58,6 @@ module.exports = function (Groups) {
 			...data,
 			paginate: false,
 			hardCap: -1,
-			groupName: data.groupName,
 		});
 
 		const uids = results.users.map(user => user && user.uid);
diff --git a/src/socket.io/groups.js b/src/socket.io/groups.js
index 3282e76b0966..0ab9ec94b435 100644
--- a/src/socket.io/groups.js
+++ b/src/socket.io/groups.js
@@ -326,7 +326,6 @@ SocketGroups.loadMore = async (socket, data) => {
 };
 
 SocketGroups.searchMembers = async (socket, data) => {
-	data.uid = socket.uid;
 	const [isOwner, isMember, isAdmin] = await Promise.all([
 		groups.ownership.isOwner(socket.uid, data.groupName),
 		groups.isMember(socket.uid, data.groupName),
@@ -335,7 +334,11 @@ SocketGroups.searchMembers = async (socket, data) => {
 	if (!isOwner && !isMember && !isAdmin) {
 		throw new Error('[[error:no-privileges]]');
 	}
-	return await groups.searchMembers(data);
+	return await groups.searchMembers({
+		uid: socket.uid,
+		query: data.query,
+		groupName: data.groupName,
+	});
 };
 
 SocketGroups.loadMoreMembers = async (socket, data) => {