New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache buster failure fallback #1006

Closed
julianlam opened this Issue Feb 11, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@julianlam
Member

julianlam commented Feb 11, 2014

Currently, cache buster is enabled on non development runs of NodeBB. This cache buster string is generated by running git describe --tags on the system. However, on some systems (Mac OS X), this command errors out with a fatal: No names found, cannot describe anything..

If this happens, we proceed without a cache buster, but we should fallback instead.

If git describe --tags fails for whatever reason (for example, I believe @akhoury's environment does not use git?), we should fall back to a different method of cache buster generation.

My suggestion is to have ./nodebb upgrade touch package.json. Therefore, we can read its' last modified date, and use that timestamp as a cache buster.

@julianlam julianlam added this to the 0.3.2 milestone Feb 11, 2014

@julianlam julianlam self-assigned this Feb 11, 2014

@akhoury

This comment has been minimized.

Show comment
Hide comment
@akhoury

akhoury Feb 11, 2014

Contributor

neato ! i like the touch package.json idea

Contributor

akhoury commented Feb 11, 2014

neato ! i like the touch package.json idea

@psychobunny

This comment has been minimized.

Show comment
Hide comment
@psychobunny

psychobunny Feb 11, 2014

Member

nice touch.
On 2014-02-11 6:31 PM, "Aziz Khoury" notifications@github.com wrote:

neato ! i like the touch package.json idea

Reply to this email directly or view it on GitHubhttps://github.com/NodeBB/NodeBB/issues/1006#issuecomment-34821872
.

Member

psychobunny commented Feb 11, 2014

nice touch.
On 2014-02-11 6:31 PM, "Aziz Khoury" notifications@github.com wrote:

neato ! i like the touch package.json idea

Reply to this email directly or view it on GitHubhttps://github.com/NodeBB/NodeBB/issues/1006#issuecomment-34821872
.

@julianlam

This comment has been minimized.

Show comment
Hide comment
@julianlam

julianlam Feb 11, 2014

Member

#iseewhatyoudidthere

Member

julianlam commented Feb 11, 2014

#iseewhatyoudidthere

@julianlam julianlam closed this in e2c6eca Feb 13, 2014

@akhoury

This comment has been minimized.

Show comment
Hide comment
@akhoury

akhoury Feb 13, 2014

Contributor

thanks

Contributor

akhoury commented Feb 13, 2014

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment