Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/register/abort should check for CSRF token #11017

Closed
julianlam opened this issue Nov 9, 2022 · 0 comments
Closed

/register/abort should check for CSRF token #11017

julianlam opened this issue Nov 9, 2022 · 0 comments
Assignees
Labels

Comments

@julianlam
Copy link
Member

https://github.com/NodeBB/nodebb-theme-persona/blob/98edd2c19ae934414dc7519bb01c9ef0bb10ee56/templates/registerComplete.tpl#L43-L51

Does not pass in CSRF token.

router.post('/register/abort', controllers.authentication.registerAbort);

Does not check for CSRF token.


As far as exploitation goes, effect is limited (it just stops people from being able to register), and requires local access to machine, so this isn't classified as a vulnerability, just a best-practice nice-to-have.

@julianlam julianlam added the bug label Nov 9, 2022
@julianlam julianlam self-assigned this Nov 9, 2022
julianlam added a commit to NodeBB/nodebb-theme-persona that referenced this issue Nov 9, 2022
julianlam added a commit to NodeBB/nodebb-theme-vanilla that referenced this issue Nov 9, 2022
julianlam added a commit to NodeBB/nodebb-theme-persona that referenced this issue Nov 9, 2022
julianlam added a commit that referenced this issue Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant