Unable to leave chat room

[uplift]

The below caller.uid needs a parseInt wrapped around it for the equality check to be true otherwise it falls into the else and errors if you arent the owner of the chat room

NodeBB/src/api/chats.js

Lines 112 to 116 in 24e58c2

	if (data.uids.length === 1 && parseInt(data.uids[0], 10) === caller.uid) {
	await messaging.leaveRoom([caller.uid], data.roomId);
	} else {
	await messaging.removeUsersFromRoom(caller.uid, data.uids, data.roomId);
	}

[barisusakli]

What version of nodebb? And how do you reproduce? I tried to leave a room that I am not the owner of and it worked fine. caller.uid is either req.uid or socket.uid both are numbers. 🤔

[uplift]

v2.8.1

I forgot to add this is through the API.

The caller.uid is definitely a string if I typeof the value.

Also using Session Sharing plugin if that impacts it

[barisusakli]

Can you share how you are calling the api? I want to find out how req.uid is becoming a string. Maybe add a console.log(new Error('a').stack) right before the if check

[uplift]

The api url is

setupApiRoute(router, 'delete', '/:roomId/users/:uid', [...middlewares, middleware.assert.room, middleware.assert.user], controllers.write.chats.kickUser);

Stack trace:-

Chats.kickUser (\src\controllers\write\chats.js:83:16)
at async \src\routes\helpers.js:73:5

[barisusakli]

I meant how are you making the request to the API? via curl or something else etc?

[uplift]

Through our web app using Master token and ?_uid=XXX for the forum id

[barisusakli]

👍🏼 I will take a look, we will probably parseInt the _uid when we get it on our side so we don't have to parseInt all the caller.uid variables everywhere.

[barisusakli]

Can you test the above change?

[uplift]

That works great 👍