New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Consider Nodemailer instead #3756

Closed
psychobunny opened this Issue Oct 14, 2015 · 12 comments

Comments

Projects
None yet
5 participants
@psychobunny
Copy link
Member

psychobunny commented Oct 14, 2015

https://github.com/andris9/Nodemailer

Ghost uses this. Seems better than handrolling our own emailer plugins, and it has a ton of other features as well

@pitaj

This comment has been minimized.

Copy link
Contributor

pitaj commented Oct 17, 2015

👍 Absolutely. Would make emailer plugins about 2000% easier.

There are already transports for mailgun, mandrill, etc

@psychobunny

This comment has been minimized.

Copy link
Member

psychobunny commented Oct 18, 2015

The other neat thing is that it automatically translates the plaintext version

Right now nodebb requires you to write two templates per email

@julianlam

This comment has been minimized.

Copy link
Member

julianlam commented Oct 29, 2015

Wouldn't mind tackling this and moving from RFC to Enhancement.

Main stopper from doing this before was that I didn't have a reliable way to send email without using a dependency (e.g. sendmail, postfix) or third-party service (mandrill, sendmail).

Now, things have changed:

  • We have a system set up so that third-party emailers can be used
  • NodeMailer has a direct transport so emails can (somewhat unreliably) be sent without need of a dependency
  • Mandrill (our preferred emailer) no longer has a free tier, which makes their service less attractive to forums looking to minimise expenses

Also if no emailer is installed, NodeBB simply doesn't do anything at the moment, so I'd imagine doing something, even if it doesn't always make it to the inbox, is better than nothing...

@julianlam julianlam self-assigned this Oct 29, 2015

@pitaj

This comment has been minimized.

Copy link
Contributor

pitaj commented Oct 29, 2015

👍 absolutely. If anything, you can just ask people to whitelist the forum email.

@lots0logs

This comment has been minimized.

Copy link
Contributor

lots0logs commented Oct 30, 2015

Mandrill (our preferred emailer) no longer has a free tier, which makes their service less attractive to forums looking to minimise expenses

Mailgun still has a free tier. I've been using their service for a couple years without issue. Would this change still allow use of services like Mailgun?

@pitaj

This comment has been minimized.

Copy link
Contributor

pitaj commented Oct 30, 2015

@lots0logs I'm thinking that's an "of course"

NodeMailer has plugins for Mailgun, Mandrill, etc so it would actually be much easier to keep everything up to date.

@julianlam

This comment has been minimized.

Copy link
Member

julianlam commented Oct 30, 2015

I can't find a free tier on their website (last I checked was perhaps a
month ago so maybe things changed)... Maybe it's just not advertised?

On Thu, 29 Oct 2015 21:05 Peter Jaszkowiak notifications@github.com wrote:

@lots0logs https://github.com/lots0logs I'm thinking that's an "of
course"

NodeMailer has plugins for Mailgun, Mandrill, etc so it would actually be
much easier to keep everything up to date.


Reply to this email directly or view it on GitHub
#3756 (comment).

@lots0logs

This comment has been minimized.

Copy link
Contributor

lots0logs commented Oct 30, 2015

@julianlam I think you misunderstood me. I mentioned Mailgun's free tier as an alternative to Mandrill since they no longer offer one.

@akhoury

This comment has been minimized.

Copy link
Contributor

akhoury commented Oct 30, 2015

+1

@julianlam

This comment has been minimized.

Copy link
Member

julianlam commented Nov 6, 2015

@pitaj Right now not entirely sure how we'd hook existing emailer plugins into the nodemailer transport, but I can probably work on a basic version for situations where you have no emailer plugin installed/setup at all...

@julianlam julianlam closed this in 48b5bab Nov 6, 2015

julianlam added a commit that referenced this issue Nov 6, 2015

@julianlam

This comment has been minimized.

Copy link
Member

julianlam commented Nov 6, 2015

Using nodemailer direct transport to send emails if no emailer is available.

julianlam added a commit that referenced this issue Nov 6, 2015

@julianlam julianlam added this to the 0.9.0 milestone Nov 6, 2015

@pitaj

This comment has been minimized.

Copy link
Contributor

pitaj commented Nov 6, 2015

Right now not entirely sure how we'd hook existing emailer plugins into the nodemailer transport

Yeah, seems like you'd need a new hook or something for that.

Anyways, you ought to warn the user about using direct transport, and how it can be marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment