Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor src/favourites.js #5096

Closed
barisusakli opened this issue Oct 8, 2016 · 0 comments
Closed

refactor src/favourites.js #5096

barisusakli opened this issue Oct 8, 2016 · 0 comments

Comments

@barisusakli
Copy link
Member

rename uid:<uid>:favourites to uid:<uid>:bookmarks
rename pid:<pid>:users_favourited to pid:<pid>:users_bookmarked
rename /favourites route to /bookmarks
rename post field reputation to bookmarks
separate vote and bookmark code
fix language strings referencing favourites
write tests for upvote/unvote/downvote and bookmark/unbookmark

@barisusakli barisusakli added this to the 1.3.0 milestone Oct 8, 2016
@barisusakli barisusakli self-assigned this Oct 8, 2016
barisusakli added a commit to NodeBB/nodebb-theme-persona that referenced this issue Oct 8, 2016
barisusakli added a commit to NodeBB/nodebb-theme-vanilla that referenced this issue Oct 8, 2016
yariplus pushed a commit to yariplus/nodebb-theme-persona that referenced this issue May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant