Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Sass #5874

Open
axynos opened this issue Aug 12, 2017 · 9 comments

Comments

Projects
None yet
5 participants
@axynos
Copy link

commented Aug 12, 2017

I saw the previous issue (#3737) about it and saw that support for sass would be considered when bootstrap 4 hits beta.

That has now happened, so I'd like to make a request for this again.

In a perfect world, I'd ask for the ability for theme devs to choose their own framework to use (I personally love iota-CSS and would prefer to use it over bootstrap 4) but I'm not sure how tied in bootstrap is to everything.

@pichalite

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2017

@axynos Unfortunately bootstrap is tied in to too many things in NodeBB. Not easy to remove the dependency.

@julianlam

This comment has been minimized.

Copy link
Member

commented Aug 18, 2017

It is not impossible, but as @pichalite says, it is not easy.

@pitaj @yariplus perhaps one of you can investigate the feasibility of doing SASS... if the writing is truly on the wall for LESS.

@pitaj

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2017

It would make everything easier if the CSS framework was tied to the theme and only the theme, but supporting plugins makes things more difficult.

If we want to go that way, we could deprecate using bootstrap entirely and load it when needed.

@Foorack

This comment has been minimized.

Copy link

commented Dec 12, 2017

Any update on this?
Considering of using NodeBB and interested in designing a theme using Bootstrap 4.

@Foorack

This comment has been minimized.

Copy link

commented Mar 20, 2018

@julianlam Any updates on this? Bootstrap 4 was released in January. If usage of bootstrap is not deprecated then can it at least be updated?

@pitaj

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2018

Bootstrap 4 is a huge breaking change, it would break all plugins.

@Foorack

This comment has been minimized.

Copy link

commented Mar 20, 2018

Bootstrap 4 is a huge breaking change, it would break all plugins.

@pitaj Yes, it will be a huge task, therefore planning should have started way back ago when Bootstrap 4 development was announced. Migration or possibly decoupling from Bootstrap should have started long time ago.

@Foorack

This comment has been minimized.

Copy link

commented Apr 11, 2018

Any update on this? If it is not going to be removed, is there at least any planned upgrade path to Bootstrap 4?

@julianlam

This comment has been minimized.

Copy link
Member

commented Apr 11, 2018

Not at present -- our focus now is on releasing 1.9.0 with proper GDPR support, at which time we'll tentatively take a look at BS4 afterwards.

In terms of upgrade path, we'd likely need plugins rewritten to use the proper bs4 components, though we'll likely still support LESS compilation so as to not break backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.