New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS Feed Authentication only works for topics/categories not Recent #5903

Closed
king-cat opened this Issue Aug 29, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@king-cat
Copy link

king-cat commented Aug 29, 2017

I think this was intended behavior, or at least an oversight, not a bug. I would like to request the Recent feed be added to the capability of using the RSS token.

Alternatively, if someone can give me a rough overview of what needs to be added and where I can do it myself and submit a PR. I tried looking at the original PR for adding rss tokens but so much was added it's unclear what exactly would need to be ported to the recent feed to get it to work.

I'm on nodebb 1.5.3 with redis if that matters.

@julianlam

This comment has been minimized.

Copy link
Member

julianlam commented Aug 29, 2017

I don't believe the /recent branch is hidden from guests, so it is always accessible. Hence no need for the user auth token. Correct me if I'm wrong 😄

@king-cat

This comment has been minimized.

Copy link

king-cat commented Aug 29, 2017

That recent branch is not hidden no, but it wont show any posts that aren't visible to guests so... it kinda is hidden lol. You just get an empty response.

@barisusakli barisusakli self-assigned this Sep 21, 2017

@barisusakli barisusakli added this to the 1.6.1 milestone Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment