Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Digest settings are being ignored #6126

Closed
phit opened this issue Nov 27, 2017 · 12 comments
Closed

User Digest settings are being ignored #6126

phit opened this issue Nov 27, 2017 · 12 comments
Assignees

Comments

@phit
Copy link
Contributor

phit commented Nov 27, 2017

  • NodeBB version: 1.6.x

  • NodeBB git hash: 95f7b7b

  • Database type: mongo

  • Exact steps to cause this issue:
    multiple users reported to me that they are getting digest emails since my update to 1.6.x, even though they have their digest settings to off

    forum is set to weekly digest by default in the ACP, looks like that setting is used instead of the settings set by the user?

  • What you expected:
    not getting mails

  • What happened instead:
    they get mails

I wonder if this was introduced with the fix in #5770 and NodeBB somehow thinks those users had never saved their settings even though they did just a long time ago

@julianlam
Copy link
Member

julianlam commented Nov 28, 2017

@phit Unfortunately I haven't been able to reproduce (at least, via our testing suite).

I added a couple new tests to test this specifically, and they all passed: #6130

Can you check their profile settings yourself (as you are admin) and verify that it is indeed "off"?

@phit
Copy link
Contributor Author

phit commented Nov 28, 2017

Yeah I did for multiple people, before reporting this. They all named the first sunday after I updated the forums as the date this started.

@julianlam
Copy link
Member

In that case it could very well be that the changes @baris made fixes this. Can you try upgrading to v1.7.0?

@phit
Copy link
Contributor Author

phit commented Nov 28, 2017

Yeah, it's on my to-do just haven't found time to locally test the upgrade.

@julianlam
Copy link
Member

Great, please do let us know when you have a chance 😄 I will pre-emptively close this for now.

@henrikekblad
Copy link

Hi,

Something is definitely behaving differently since we upgraded to 1.7.2 a few days ago.

Looks like we're sending out digest emails to all our members. This has raised (angry) reactions from members that previously opted out for these emails.

screen shot 2017-12-10 at 22 01 45

Anything we can do short-term to solve this until it has been fixed? (Like temporary disabling digests for all users?)

@barisusakli
Copy link
Member

Can you go to /admin/settings/user#default-user-settings and check if digest is set to off?

@henrikekblad
Copy link

henrikekblad commented Dec 10, 2017

It's set to weekly.

screen shot 2017-12-10 at 22 27 06

Hmm... wonder why it didn't send to (almost) all users in the earlier version?

We did enable the confirm email feature a year back. Do you send out digests to unconfirmed accounts?

@barisusakli
Copy link
Member

Could be due to a bug that was fixed. If you set that to off your issue should be fixed.

@mfalkvidd
Copy link

Will setting it to off affect users who have actively selected to receive weekly digests?

@phit
Copy link
Contributor Author

phit commented Dec 11, 2017

from my experience, no, users that have explicitly selected something are not affected by the default value

@barisusakli
Copy link
Member

That's correct the default only affects users who haven't explicitly set their settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants