New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server-side skin building issues #7266
Comments
Seems like the body class never gets added the |
Was positive I didn't remove that logic, but I will check, thanks |
alright cherry picking these, seems to work! unfortunately there still seem to be compilation issues, lets take the case of the padding and background color are all messed up for it and there's tons of issues like this, neither the background nor the padding should be 0 here is the compiled bootswatch css https://github.com/thomaspark/bootswatch/blob/v3.3.7/lumen/bootstrap.css#L4697 actually i looked everywhere in all the less files that should be pulled in and nowhere i could find the reference to that |
Breadcrumbs are wonky on lumen only? |
I do not know how other themes looked before, so I have a hard time spotting changes, another thing I've noticed are the font color being you can see in that screenshot even code highlighting broke and the font is just |
@julianlam mind reopening so this doesn't get forgotten? |
Padding is defined zero here: https://github.com/NodeBB/nodebb-theme-persona/blob/master/less/header.less#L271 It seems most of the issues described here are due to overrides in Persona that might no longer be needed now that skins are handled server-side. |
okay, so we just have to live will all themes being mostly broken? |
The code highlighting issue seems to only apply on a hard load, not when ajaxify is involved. Just tested it on sandstone on the same topic. |
@phit do you mean all skins? |
Highlighting is broken even on Default, aka no skin, so something else is going on there. |
alright that's hard load then, anyway, yes i meant skins, some kind of order must have changed, as previously bootstrap would override the persona css |
Could you give some specific examples besides the code highlighting? |
padding in general seems to vary wildly from the previous versions, pretty much everywhere i mean just look at the shift in #7266 (comment) then theres random font color changes, another easy one to spot is, breadcrumbs as mentioned before is the easiest to spot even if you haven't looked at the skins in detail before |
The thing is, these changes might actually be because now the skins are actually being applied correctly. Skins are now compiled inside less with the persona theme, so their variable changes and whatnot are more consistently applied. I think it's likely that what used to be base bootstrap variables in the precompiled skins overriding persona variables are no longer showing up. |
sounds about right, but the result is persona overwriting the bootstrap theme and it looks terrible the fix of applying the skin manually like I do right now shouldn't do anything, right now i put the bootstrap css after the generated stylesheet so it is overwritten and it solves all the issues I'm having.. |
@pitaj is right, it is because we are now properly loading skins and Persona is overwriting them. However that doesn't indicate a problem with the server-side skin building logic, which is why the issue was closed. I'd recommend tracking these changes in a new issue so they can be individually looked at and fixed properly. |
use persona with e.g. the lumen theme
upgrade from 1.9.x
look at your theme
to look the same as before
looks different/broken
another big issue for wanting to edit bootswatch themes the body classes no longer includes the actual active skin its just
skin-
, it should always have the skin name there like before even when the user is using the default skin (default being whatever I selected in the admin panel)the easiest way to spot this is looking at the headcrumb in the category overview
before https://i.imgur.com/o9qLjRk.png
after https://i.imgur.com/RMYTPvd.png
for now i disabled users switching skin and added the old theme to the custom header
i also tried
npm i bootswatch@3.3.7
as 3.4.0 was installed by the^3
set in the package.json but no luckThe text was updated successfully, but these errors were encountered: