Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really really long groups break things. #7447

Closed
PatheticMustan opened this Issue Mar 13, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@PatheticMustan
Copy link

PatheticMustan commented Mar 13, 2019

  • NodeBB version: 1.12.0

  • NodeBB git hash: 9c4b2d9

  • Database type: mongo

  • Database version: 4.0.6

  • Exact steps to cause this issue:

  1. Have really, really, really long group names.
  2. Make a post.
  • What you expected:
    I expected my posts to be normal, and for the text to fit in the boxes.

  • What happened instead:
    The group name didn't fit in the box, and all my posts are invisible.

What the post looks like normally...
Screenshot (103)
After adding a ton of long group names.
Screenshot (106)

And more screenshots of things not fitting where they should fit in anyways
Screenshot (102)
Screenshot (104)
Screenshot (105)

Kinda related to #7065

@PatheticMustan

This comment has been minimized.

Copy link
Author

PatheticMustan commented Mar 13, 2019

Maybe instead of "Superlongnamethatshouldntbepossiblebutisindeedinfactio", it can be shortened, like "Superlongnamethatsho..."
Also, long usernames break things as well.

@pitaj

This comment has been minimized.

Copy link
Contributor

pitaj commented Mar 13, 2019

Maybe we should add a limit to the length of group names and user names.

@PatheticMustan

This comment has been minimized.

Copy link
Author

PatheticMustan commented Mar 13, 2019

Isn't there already a limit?
(If the limit is high enough, usernames can break things too)

@julianlam

This comment has been minimized.

Copy link
Member

julianlam commented Mar 13, 2019

Group names can be long, I have no objection to that.. however, I'd argue that badges should have a cap on name length. This is up to the theme to implement and I'll add it in for Persona and Vanilla.

julianlam added a commit to NodeBB/nodebb-theme-persona that referenced this issue Mar 13, 2019

julianlam added a commit to NodeBB/nodebb-theme-vanilla that referenced this issue Mar 13, 2019

@julianlam julianlam self-assigned this Mar 13, 2019

@julianlam julianlam added this to the 1.12.1 milestone Mar 13, 2019

@julianlam julianlam closed this Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.