Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If mobile navigator dragscroll is invoked with a higher vertical scroll than horizontal, it should cancel #7464

Closed
julianlam opened this issue Mar 16, 2019 · 0 comments
Assignees
Milestone

Comments

@julianlam
Copy link
Member

Details here: https://what.thedailywtf.com/topic/26328/del-scroll-del-ins-page-ins-up

Basically, if invoked, the drag scroll listener allows you to go to a specific page or post, or something like that. However attempts to scroll up when starting from the bar will cause the page to ajaxify elsewhere, which is not the desired effect.

If the vertical scroll is > horizontal scroll, it can be assumed that it was meant to be a scroll up and so we can do nothing instead.

For small navigations (where horizontal scroll might be too small), perhaps we can adjust the logic so that the vert>horiz check is only triggered if vert > 2x navbar height

@barisusakli barisusakli self-assigned this Apr 26, 2019
@barisusakli barisusakli added this to the 1.12.2 milestone Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants